Grant Details Formatting Updates

ClaireValdivia commented 8 months ago

adjustments to clean up formatting and display on grant details page

[ ] On grant detail pages, the Award Ceiling number should be formatted to be currency (i.e. currently displays as 50000; it should be "$50,000" - this will be consistent with the display on the results tables
[ ] the values displayed for Opportunity Status (i.e. Posted, Closed, Archived) should be updated to be capitalized
[ ] On grant details page, current field is incorrectly named "Federal Awarding" - this should be "Agency Code"

Currency formatting: We currently do currency formatting on the frontend here and here. We refactor that into a helper function in src/helpers/..., then we can use it to format the award ceiling value here: https://github.com/usdigitalresponse/usdr-gost/blob/9856006dbad9ff47bd87679681bc4de1405eb61d/packages/client/src/views/GrantDetails.vue#L273
Opportunity status: Capitalize the first character of the opportunity status value here: https://github.com/usdigitalresponse/usdr-gost/blob/9856006dbad9ff47bd87679681bc4de1405eb61d/packages/client/src/views/GrantDetails.vue#L282
Field name: Change to the correct name here: https://github.com/usdigitalresponse/usdr-gost/blob/9856006dbad9ff47bd87679681bc4de1405eb61d/packages/client/src/views/GrantDetails.vue#L269

No response

ClaireValdivia commented 8 months ago

@jeffsmohan are you able to draft implementation details for this one as well please?

jeffsmohan commented 8 months ago

@ClaireValdivia implementation details added!

ClaireValdivia commented 8 months ago

took out opening mailto link in new tab as we will be opening a new issue for copying the email instead. posting the implementation details for mailto in a new tab just in case we need it later Email in new tab: Add a target="_blank" attribute to the mailto link here: https://github.com/usdigitalresponse/usdr-gost/blob/9856006dbad9ff47bd87679681bc4de1405eb61d/packages/client/src/views/GrantDetails.vue#L141

ClaireValdivia commented 8 months ago

This looks great in staging!

usdigitalresponse / usdr-gost