Open ClaireValdivia opened 7 months ago
See Sam's prototype for copy / toast behavior.
Please Note
The prototype has an alternative toast version, as seen with the last user on the page, "David Saris." This toast is in line with that table row and appears directly next to the email link the user has clicked. I find this more evident in this context than our 'full page' toast seen with the other users, and I welcome discussion on which version to take.
Thanks Sam! a few follow up questions for @samserif23 and @caitlinwinner
Hi Claire, Initial responses are below. Will talk through these with Caitlin and edit as necessary:
For all of these inline toasts, I imagine they cover up the tail end of the information (e.g., emails) instead of wrapping anything and re-structuring page elements. Toasts would be visible for 3-5 seconds, which wouldn't hinder any information for that long.
For the primary toast, I would display it in the exact location, no matter the page. If we decide on the bottom right, it would be anchored from the bottom of the viewport + right margin
I am uploading a design prototype for the grants detail page. Both show an inline-toast since we copy emails (a low-impact action).
Naming conventions:
@ClaireValdivia Link to Figma > USDR Design System > Toast Component
@TylerHendrickson acceptance criteria and designs have been added, passing to you for implementation details! let me know of any questions
@samserif23 What do you think about changing the icon to the left of the email address to the Bootstrap files
icon instead of removing the icon altogether?
I see two benefits in moving to the files
icon:
mailto:
link.Here's an example of what this would look like according to our styling:
@TylerHendrickson @caitlinwinner Ty, our initial decision to remove the icon was to avoid having something redundant on each line, for instance, if we had multiple email addresses in that section.
I agree with your two benefits in helping users understand this is a copy action. What do you think about the icon appearing only on hover and to the right of the email value so as not to shift the text?
To my eyes, it looks like there are enough lines of text and blank space separating the email addresses that the copy icon doesn't feel like significant visual clutter when there are multiple email addresses.
Regarding the right-hover icon, I think the caveat is that the copy action only becomes apparent when the a user is already interacting with the text in some way, so it doesn't really "advertise" the functionality. That said, I'm happy to defer to you on what makes the most sense here.
On a slightly different topic, I'm not able to find a Bootstrap toast behavior that fully conforms to the Figma designs – what would you think about using a tooltip instead?
@samserif23 To offer another example, @jeffsmohan mentioned that GitHub has a pretty solid implementation of this type of behavior in Pull Request views, and provided this example:
https://github.com/usdigitalresponse/usdr-gost/assets/1851017/56310a51-f37f-45a1-830c-193786a205ce
Thoughts?
I believe the GitHub solution works best.
I'm still thinking the icon should be on the right because on the left, it reads more like a value_type than an action.
@ClaireValdivia Implementation details added.
@ClaireValdivia totally happy to keep this out of scope for this issue, but I'm curious if we want to try to make the copy behavior more consistent between the emails here and the big "copy link" button at the top of the page.
@jeffsmohan Regarding the confirmation time, the 1s confirmation should work fine for the tooltip since we are moving away from our in-line toast.
just confirming also that we're good with the separate UIs for now. thanks for raising, Jeff!
Why is this issue important?
behavior for clicking mailto links is confusing and very dependent on user's mail settings
Current State
On new grant details page, under Team Status, a user's email appears as a mailto: link under the status they applied
Expected State
Acceptance Criteria:
Implementation Plan
packages/client/src/components
that implements the following:navigator.clipboard.writeText()
)"Copied"
.Team Status
section makes use of the new custom component.mailto:
handler.Relevant Code Snippets
Rough draft provided by @jeffsmohan