Open TylerHendrickson opened 2 months ago
@greg-adams seeing a PR for this issue in staging and just want to confirm if I should be expecting that PR to address all aspects of this issue? a couple quick notes of what I'm seeing:
@ClaireValdivia Looks like we just needed to migrate the latest DB push - I smoke tested, and it should be good to test now
@greg-adams thanks so much - this is looking so good and I'm not seeing these errors pop up anymore!
a few items I noticed:
@ClaireValdivia thanks for taking a look - just some things to note:
The text above asks that the "Share Grant" component be replaced by this new one. No problem to include all 3 cards, please let me know the correct order vertically.
The grant activity card has some extra space at the bottom to hold a footer where the forthcoming notes feed section https://github.com/usdigitalresponse/usdr-gost/issues/3428 will go.
Ah, that is 100% our bad. sorry about that! - it is the "Status" section that should be replaced. What we expect to see when the feature flag is on is that Grant Activity and Share sections shows (and Status does not), matching the designs here: figma designs
Subtask of [STORY]: Update 'Status' to 'Follow + Note' feature #2960
Blocked by
3205
3405
3399
3411
Blocks
3407
3428
Definition of Done
See Figma designs
When the
followNotesEnabled
feature flag istrue
, the "Team Status" component in the Grant Details view is replaced by a new "Grant Activity" component that provides the following:Followed by {{Follower Name}} and {{Count Other Followers }} others
according to the following rules:Followed by {{ Follower Name }}
should display{{ Follower Name }}
is the current user,{{ Follower Name }}
should beyou
, e.g.Followed by you
{{ Count Other Followers }} = {{ Paginated Result Count }} - 1
{{ Count Other Followers }}
is greater than 0 and less than 50, theand {{Count Other Followers }} others
text should display{{ Count Other Followers }}
is greater than or equal to 50,and {{ Count Other Followers }}+ others
text should display (note the inclusion of+
sign), e.g.and 50+ others
{{ Count Other Followers }}
, e.g.and 1 other
vsand 2 others
{{ Count Notes }}
notes{{ Count Notes }} notes
should display{{ Count Notes }}+ notes
should display (note the inclusion of the+
sign), e.g.50+ notes
{{ Count Notes }}
, e.g.1 note
vs2 notes
Followed by Firstname Lastname and 26 others • 4 notes
Implementation details
followNotesEnabled
feature flag is enabled (evaluates totrue
)The
GET /api/organizations/:organizationId/grants/:grantId/followers
route implemented in #3399 supports requests to fetch (paginated) followers of a grant within the same organization as the currently-authenticated user. This endpoint should be requested with query parameters of?limit=51
so that the response contains a maximum of 51 followers. The response body from this endpoint provides information for displaying the latest follower ({{ Follower Name }}
) as well as the total number of followers ({{ Count Followers }}
). Consider the following pseudocode as an illustration of how to derive the Follower Information display text:GET /api/organizations/:organizationId/grants/:grantId/follow
route implemented in #3411 supports requests to fetch a record that indicates whether the currently-authenticated user is a follower of a particular grant.GET /api/organizations/:organizationId/grants/:grantId/notes
route implemented in #3205 supports requests to fetch (paginated) notes for a particular grant submitted by users within the same organization as the currently-authenticated user. This endpoint should be requested with query parameters of?limit=50
so that the response contains a maximum of 50 followers. The response body from this endpoint provides information for displaying the current count of notes ({{ Count Notes }}
), capped at 50.