usdigitalresponse / usdr-gost

USDR-hosted grants management tools
http://grants.usdigitalresponse.org
Apache License 2.0
32 stars 21 forks source link

Follow+Notes: Implement Grant Activity card component in Grant Details view #3406

Open TylerHendrickson opened 2 months ago

TylerHendrickson commented 2 months ago

Subtask of [STORY]: Update 'Status' to 'Follow + Note' feature #2960

Blocked by

Blocks

Definition of Done

See Figma designs

When the followNotesEnabled feature flag is true, the "Team Status" component in the Grant Details view is replaced by a new "Grant Activity" component that provides the following:

Implementation details

ClaireValdivia commented 1 month ago

@greg-adams seeing a PR for this issue in staging and just want to confirm if I should be expecting that PR to address all aspects of this issue? a couple quick notes of what I'm seeing:

greg-adams commented 1 month ago

@ClaireValdivia Looks like we just needed to migrate the latest DB push - I smoke tested, and it should be good to test now

ClaireValdivia commented 1 month ago

@greg-adams thanks so much - this is looking so good and I'm not seeing these errors pop up anymore!

a few items I noticed:

greg-adams commented 1 month ago

@ClaireValdivia thanks for taking a look - just some things to note:

ClaireValdivia commented 1 month ago

Ah, that is 100% our bad. sorry about that! - it is the "Status" section that should be replaced. What we expect to see when the feature flag is on is that Grant Activity and Share sections shows (and Status does not), matching the designs here: figma designs