usdigitalresponse / usdr-gost

USDR-hosted grants management tools
http://grants.usdigitalresponse.org
Apache License 2.0
29 stars 20 forks source link

Linting is disabled for arpa_reporter #839

Open NatHillardUSDR opened 1 year ago

NatHillardUSDR commented 1 year ago

Github is currently complaining in various PRs about line length violations.

We should fix both the violation and the linter rule that is prompting them

Original theory:

in .editorconfig we currently have the line max_line_length = 100. This is presumably intended to offer cross-IDE standardization of line-length.

Locally, however, this restriction is also enforced by eslint, which uses more sophisticated notions of appropriate line length per file-type and even per function context. As it stands, I’m not sure this line is adding much! Github is apparently also picking this up, and seems to be complaining on all current PRs. It seems the easiest way to cut down on this is to remove the line from .editorconfig and just rely on eslint

NatHillardUSDR commented 1 year ago

D'oh - I discovered after this merge that, while this does help with local IDE errors, it doesn't address the errors on github, which actually are coming from eslint -- this is coming from Build website deployment artifact in Build GOST Website, as seen here.

In turn, these aren't being caught by standard processes because of these lines:

        // NOTE(mbroussard): this is temporary, just to make committing on ARPA integration dev branch a bit
    // less annoying.
    'src/arpa_reporter/**/*',
    'tests/**/arpa_reporter/**/*',
  ],

So - the real fix for the github annoyingness is to 1)undersetand what the original annoyingness was all about, 2) remove this ignore, then 3) fix the errors with eslint

ClaireValdivia commented 11 months ago

@ajhyndman can you confirm if this ticket was addressed? Thanks!