Open NatHillardUSDR opened 1 year ago
D'oh - I discovered after this merge that, while this does help with local IDE errors, it doesn't address the errors on github, which actually are coming from eslint -- this is coming from Build website deployment artifact
in Build GOST Website
, as seen here.
In turn, these aren't being caught by standard processes because of these lines:
// NOTE(mbroussard): this is temporary, just to make committing on ARPA integration dev branch a bit
// less annoying.
'src/arpa_reporter/**/*',
'tests/**/arpa_reporter/**/*',
],
So - the real fix for the github annoyingness is to 1)undersetand what the original annoyingness was all about, 2) remove this ignore, then 3) fix the errors with eslint
@ajhyndman can you confirm if this ticket was addressed? Thanks!
Github is currently complaining in various PRs about line length violations.
We should fix both the violation and the linter rule that is prompting them
Original theory: