search

usdot-fhwa-OPS / V2X-Hub

V2X Hub is a message handler that acts as a translator and data aggregator/disseminator for infrastructure components of a connected vehicle deployment.
Apache License 2.0
123 stars 69 forks source link

J2735 2020 upgrade #568

Closed jwillmartin closed 9 months ago

jwillmartin commented 1 year ago

PR Details

Description

Upgrades include new ASN1 folders containing 2020 version of J2735. Changes were made to many files to allow for use of older and this new standard. These changes are indicated by "#if SAEJ2735_SPEC < 2020". This line specifies which standard is to be used by V2X Hub: https://github.com/usdot-fhwa-OPS/V2X-Hub/blob/j2735-2020-upgrade/src/tmx/Asn_J2735/CMakeLists.txt#L44

Related Issue

Motivation and Context

New versions of the standard are being published. These changes are required to keep up with industry needs.

How Has This Been Tested?

Tested all message encoding/decoding with these unit tests: https://github.com/usdot-fhwa-OPS/V2X-Hub/blob/j2735-2020-upgrade/src/tmx/TmxUtils/test/J2735MessageTest.cpp Additional testing was completed on a local instance to ensure messages were generated properly and adhered to the updated standard. Encoded messages were cross-checked with an existing decoder: https://www.marben-products.com/decoder-asn1-automotive/

Types of changes

Checklist:

paulbourelly999 commented 1 year ago

We may want to consider holding off on merging this until we cut a release candidate for VRU. This is a very large change set that spans many pieces of commonly used functionality. I think merging this before VRU integration testing poses substantial risk to the testing

paulbourelly999 commented 9 months ago

@jwillmartin @dan-du-car This can be merged into develop now if it is approved. We have release candidates for VRU so it won't impact our testing. Please resolve merge conflicts before merging.