dan-du-car commented 5 months ago

PR Details

Description

Fix the TCM intermittent reception issue where carma cloud sends TCMs in an http request and v2xhub CARMACloudPlugin sometimes does not receive the TCMs. Replace the OpenAI generated code with QhttpEngine recommended functional call, refer to: https://ci.quickmediasolutions.com/job/qhttpengine-documentation/doxygen/classQHttpEngine_1_1QObjectHandler.html.

Motivation and Context

CARMA cloud integration testing

How Has This Been Tested?

Local integration test

Types of changes

[x] Defect fix (non-breaking change that fixes an issue)
[ ] New feature (non-breaking change that adds functionality)
[ ] Breaking change (fix or feature that cause existing functionality to change)

Checklist:

[ ] I have added any new packages to the sonar-scanner.properties file
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document. V2XHUB Contributing Guide
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.

paulbourelly999 commented 5 months ago

@dan-du-car Wait so the edits are not on the generated code, That makes sense. You mentioned it is a replacement of generated code. Does that mean some of the generated code can be removed? You also mentioned that this is an issue with other OpenAPI generated REST clients/servers. If so we should create issues to remove the problematic code and include any evidence you have of these other services having similar issues.

@paulbourelly999 The generated code is in the server lib. I think some OpenAI related code in the CARMACloudPlugin is a copy with some modification from there: https://github.com/usdot-fhwa-OPS/V2X-Hub/blob/develop/ext/server/src/main.cpp.