usdot-fhwa-OPS / V2X-Hub

V2X Hub is a message handler that acts as a translator and data aggregator/disseminator for infrastructure components of a connected vehicle deployment.
Apache License 2.0
123 stars 69 forks source link

Fix ped plugin #620

Closed jwillmartin closed 3 months ago

jwillmartin commented 5 months ago

PR Details

Description

These changes address a memory leak in the WebService/PSM functionality of the plugin. It also allows a user to switch between using FLIR(WebSocket) and PSM(WebService) without crashing or generating segmentation faults.

Related Issue

497

Motivation and Context

Users of this plugin have noticed memory loss and error code generation while using this plugin. Users have also requested a fix for the #497 issue.

How Has This Been Tested?

Tested using a script to send 1000 PSM XMLs to the plugin. No messages were lost. Tested using local FLIR camera to ensure functionality was maintained.

Switched between DataProviders (PSM/FLIR) in various combinations to ensure threads were closed or joined properly.

Types of changes

Checklist:

sonarcloud[bot] commented 5 months ago

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Line Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

sonarcloud[bot] commented 3 months ago

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Line Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud