usdot-fhwa-stol / carma-analytics-fotda

CARMA Analytics is a secure, scalable and cloud agnostic data architecture to enable research analysis on big data sets by defining repeatable and scalable processes for ingesting data, creation of a data repository to fuse, process and perform quality assurance.

Apache License 2.0

3 stars 3 forks source link

added scripts for visualizing and calculating metrics for c1t develop… #70

Closed john-chrosniak closed 4 months ago

john-chrosniak commented 4 months ago

PR Details

Description

This PR includes scripts for visualizing and computing metrics for C1T

Related Jira Key

CF-846

Motivation and Context

These visualizations will help with debugging and showing progress made throughout C1T development. The metrics will also help quantify the impact of improvements.

How Has This Been Tested?

The scripts have been tested on bags recorded from the C1T trucks.

Types of changes

[ ] Defect fix (non-breaking change that fixes an issue)
[x] New feature (non-breaking change that adds functionality)
[ ] Breaking change (fix or feature that cause existing functionality to change)

Checklist:

[ ] I have added any new packages to the sonar-scanner.properties file
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.

john-chrosniak commented 4 months ago

Here are the plots generated with each script, feel free to comment on possible improvements!

calc_route_deviation plot_route_driven plot_steering_rate

adev4a commented 4 months ago

Here are the plots generated with each script, feel free to comment on possible improvements!

For plot 1, can we update the x label? Its not very clear what index is representing. For plot 2, what are the red dots? Can we add a legend to this plot? Can we also add titles to all of these plots?

john-chrosniak commented 4 months ago

For plot 1, can we update the x label? Its not very clear what index is representing.

I changed this to time in seconds to make this more clear.

For plot 2, what are the red dots? Can we add a legend to this plot? Can we also add titles to all of these plots?

The red dots are the route we intend to follow and the blue line is the actual path driven. I added a legend to indicate this and added titles as well.

john-chrosniak commented 4 months ago

plot_steering_rate plot_route_driven plot_absolute_deviation_from_route

Updated plots

john-chrosniak commented 4 months ago

updated_route_deviation

Changed x-axis of route deviation plot to downtrack

adev4a commented 4 months ago

Few small comments but this looks great overall. Thanks for updating the plots as well. One additional note - can you add a comment in each of the scripts about what they are doing? Just so that anyone looking through the script can figure out what they are meant for

john-chrosniak commented 4 months ago

crosstrack_vs_downtrack

Updated plot