usdot-fhwa-stol / carma-messenger

CARMA Messenger will be a scaled down version of CARMA Platform for a non-automated vehicle to participate in Cooperative Driving Automation (CDA). Doxygen Source Code Documentation: https://usdot-fhwa-stol.github.io/documentation/carma-messenger/

14 stars 11 forks source link

Humble arm compatability #224

Closed afrye51 closed 5 months ago

afrye51 commented 5 months ago

PR Details

Description

Added ARM asn1c shared object library, and updated the architecture check in the cmake file to also check for arm vs. x86.

Related GitHub Issue

Related Jira Key

https://usdot-carma.atlassian.net/browse/CF-836

Motivation and Context

Adding ARM and Humble compatability to carma-messenger, for the C1T project

How Has This Been Tested?

Tested building on Humble/ARM, Humble/x86, and Foxy/x86. No actual functionality was tested.

Types of changes

[ ] Defect fix (non-breaking change that fixes an issue)
[x] New feature (non-breaking change that adds functionality)
[ ] Breaking change (fix or feature that cause existing functionality to change)

Checklist:

[ ] I have added any new packages to the sonar-scanner.properties file
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.

afrye51 commented 5 months ago

There was an include for an empty service in the j2735_converter include files, but not that I look at it yeah it can just be removed instead of supported. Not sure why it was there, if there's no usage?