usdot-fhwa-stol / carma-msgs

ROS Message definitions used by the CARMA Platform
6 stars 9 forks source link

112 - Replace UTF-8 quotes with ASCII quotes #114

Closed adamlm closed 3 years ago

adamlm commented 3 years ago

PR Details

Description

Fixes issue where the quotation marks in LaneAttributesTrackedVehicle.msg were UTF-8 characters. The UTF-8 characters resulted in reading issues on systems with a non-UTF-8 locale. The UTF-8 quotes have been replaced with ASCII quotes, which resolved the issue.

Related Issue

Closes usdot-fhwa-stol/carma-msgs#112

Motivation and Context

The comment block in the LaneAttributesTrackedVehicle.msg file erroneously used UTF-8 quotation markings instead of ASCII quotes. This caused problems when a system (Docker container) using the POSIX locale tried to read the file. When the file was opened to generate the corresponding ROS message implementation, the build would crash because the quote marks could not be decoded.

How Has This Been Tested?

j2735_msgs package was built on a system using the en_US.UTF-8 locale and a system using the POSIX locale. Both systems built the package successfully after the fix.

Types of changes

Checklist: