usdot-fhwa-stol / carma-msgs

ROS Message definitions used by the CARMA Platform

6 stars 9 forks source link

Add cooperative perception interfaces #216

Closed adamlm closed 1 year ago

adamlm commented 1 year ago

PR Details

Description

This PR adds new message types to support the CARMA cooperative perception stack.

Related GitHub Issue

Closes #215

Related Jira Key

CDAR-251

Motivation and Context

These messages are specific to the cooperative perception stack.

How Has This Been Tested?

Types of changes

[x] New feature (non-breaking change that adds functionality)

Checklist:

[ ] I have added any new packages to the sonar-scanner.properties file
[x] My change requires a change to the documentation.
[x] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.

JonSmet commented 1 year ago

PR is mostly looking good! One item that I missed on my first pass is that we will need to add a ROS1 package (maybe carma_cooperative_perception_interfaces_ros1 or similar?) with identical messages as well since our team is still supporting ROS1 rosbags for data collection and analysis.

Please see carma_debug_msgs and carma_debug_ros2_msgs for an example of this.