JonSmet commented 6 months ago

PR Details

Description

This PR updates checkout.bash to change the target directory in which the ros1_bridge repo is cloned into when the BRANCH environment variable is set to develop. Prior to this change, when BRANCH was set to develop, the ros1_bridge repo was cloned into /home/carma/src, but the install.sh script only builds ROS 2 packages located at ~/.base-image/ros2_msgs_ws

Related GitHub Issue

Related Jira Key

Motivation and Context

How Has This Been Tested?

CI (docker/docker action)

Types of changes

[x] Defect fix (non-breaking change that fixes an issue)
[ ] New feature (non-breaking change that adds functionality)
[ ] Breaking change (fix or feature that cause existing functionality to change)

Checklist:

[ ] I have added any new packages to the sonar-scanner.properties file
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.

MishkaMN commented 6 months ago

This build is finishing fine, it's just that the github action is running out of space. Tested on this PR https://github.com/usdot-fhwa-stol/carma-msgs/pull/235