usdot-fhwa-stol / carma-msgs

ROS Message definitions used by the CARMA Platform

6 stars 9 forks source link

Arc 159 Remove ROS2 Foxy Specific Code #247

Closed john-chrosniak closed 1 week ago

john-chrosniak commented 1 week ago

PR Details

Description

This PR removes code that was specific to ROS2 Foxy since we plan to only support Humble in future releases.

Related GitHub Issue

NA

Related Jira Key

Motivation and Context

Part of our migration towards ROS2 Humble.

How Has This Been Tested?

Code was built inside of the ROS2 Humble carma-base docker image.

Types of changes

[ ] Defect fix (non-breaking change that fixes an issue)
[ ] New feature (non-breaking change that adds functionality)
[x] Breaking change (fix or feature that cause existing functionality to change)

Checklist:

[ ] I have added any new packages to the sonar-scanner.properties file
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.

MishkaMN commented 1 week ago

Merging assuming that the ros1_bridge build issue and docker related issues will be resolved under different PR.