MishkaMN
commented
3 months ago Interstingly, when we trigger build image with top of carma-develop branch, we are able to build the image, which I am assuming it skips the git cloning operation and builds from "cached builds"?. However, if that is the case, I am still little confused how it was able to build the cached one from the beginning:
Run docker/build-push-action@v3
GitHub Actions runtime token access controls
Docker info
Buildx version
/usr/bin/docker buildx build --iidfile /tmp/docker-build-push-UIfUNE/iidfile --tag usdotfhwastoldev/autoware.ai:develop --metadata-file /tmp/docker-build-push-UIfUNE/metadata-file --push .
#0 building with "builder-d5441fe6-8542-419c-a968-a4d0b669d5c8" instance using docker-container driver
#1 [internal] load build definition from Dockerfile
#1 transferring dockerfile: 1.18kB done
#1 DONE 0.0s
#2 [internal] load metadata for docker.io/usdotfhwastoldev/carma-base:develop
#2 ...
#3 [auth] usdotfhwastoldev/carma-base:pull token for registry-1.docker.io
#3 DONE 0.0s
#2 [internal] load metadata for docker.io/usdotfhwastoldev/carma-base:develop
#2 DONE 0.7s
#4 [internal] load .dockerignore
#4 transferring context: 500B done
#4 DONE 0.0s
#5 [base_image 1/1] FROM docker.io/usdotfhwastoldev/carma-base:develop@sha256:a5b9[21](https://github.com/usdot-fhwa-stol/autoware.ai/actions/runs/8793203268/job/24130696780#step:5:23)b6f0dc550ecabc47e3706323e8bfa14da67600aae56795f8e985056c8a
#5 resolve docker.io/usdotfhwastoldev/carma-base:develop@sha256:a5b921b6f0dc550ecabc47e3706323e8bfa14da67600aae56795f8e985056c8a done
#5 DONE 0.1s
#6 [internal] load build context
#6 transferring context: 491.36MB 4.8s done
#6 DONE 4.8sAction: https://github.com/usdot-fhwa-stol/autoware.ai/actions/runs/8793203268/job/24130696780
Summary
Therare submodules defined in autoware.ai subdirectory that are not getting correctly detected by github submodule. Not sure if this is something that always existed or something occurred due to our change Since then, the build is failing saying it was not able to find url for its submodules (please see the long error message below):
Original can be seen from this: https://github.com/usdot-fhwa-stol/autoware.ai/actions/runs/8624698002/job/23640117337
When moving these submodule declarations into the root directory of the repository, submodules are detected but it still was not possible to clone the repositories with following unknown error:
Original can be seen from this action: https://github.com/usdot-fhwa-stol/autoware.ai/actions/runs/8791371654/job/24125441576
Which leds me to believe (I could be wrong) that these submodules were never really cloned AND not needed. They were added in 4.0.0 as part of fork from autoware, and the packages we build don't seem to need them: please check this PR where basically removed the submodules https://github.com/usdot-fhwa-stol/autoware.ai/pull/268 And the build succeeds: https://github.com/usdot-fhwa-stol/autoware.ai/actions/runs/8630864827/job/23658072373?pr=268
However, I am not sure whether if this will fail at run-time or fail on features that we do not use currently such as any perception involved operations.
Version
4.5.0 (Current)
Expected Behavior
See above
Actual Behavior
See above
Steps to Reproduce the Actual Behavior
See above
Related Work
No response