Open MishkaMN opened 3 months ago
During HASS demo preparation on 06/11/2024 and VOICES Pilot 2 demo on 05/01/2024, it was discovered that other vehicles' prediction was flipping back and forth. This meant degraded yielding behavior. Therefore, needed a fix on the CTRV logic to make it work in map frame: PR https://github.com/usdot-fhwa-stol/carma-utils/pull/233, issue: https://github.com/usdot-fhwa-stol/carma-platform/issues/2398 In this PR: We are currently just passing the oriectiontation. It means it might look like vehicle moving along correct path, but may look as if facing constant direction
Summary
During carma-system-4.5.0 (lavida release), development started with carma-platform receiving detected object's velocity state in its map frame from CARLA. This meant, the linear velocity was already in map frame (non-zero x and y components for example), but not in its base_link frame which is the ROS convention (usually x non-zero with other zero because x is usually direction of travel for example). It worked out nicely with following logics already expecting velocity states in map frame as well.
However, this contradicted a prediction logic in motion_predict for example that had been developed before and doesn't work unless it is modified to expect map frame velocity as well (see 4th bullet point).
So this issue is to make everything consistent - whether it is to use map frame or base_link frame - and set the convention.
Known affected locations in carma-system-4.5.0 are (could be more):
Version
4.5.0 (Current)
Expected Behavior
See above
Actual Behavior
See above
Steps to Reproduce the Actual Behavior
NA
Related Work
https://github.com/usdot-fhwa-stol/carma-platform/issues/2407. Since all object stack is in map frame, it is prudent to warn the user if there is a potential frame mismatch.