usdot-fhwa-stol / carma-platform

CARMA Platform is built on robot operating system (ROS) and utilizes open source software (OSS) that enables Cooperative Driving Automation (CDA) features to allow Automated Driving Systems to interact and cooperate with infrastructure and other vehicles through communication. Doxygen Source Code Documentation :
https://usdot-fhwa-stol.github.io/documentation/carma-platform/
403 stars 123 forks source link

build-image.sh has wrong path to get-system-version #402

Closed kjrush closed 4 years ago

kjrush commented 5 years ago

Types of Issue

Descriptive summary

docker/build-image.sh references ./get-system-version.sh at location in the script with the PWD is at the root of the repo instead of the docker folder. This affects all dockerized CARMA repos.

Expected behavior

The ./get-system-version.sh to be ./docker/get-system-version.sh

Actual behavior


./build-image.sh: line 67: ./get-system-version.sh: No such file or directory
Error parsing reference: "usdotfhwastol/carma-novatel-gps-driver:" is not a valid repository/tag: invalid reference format
Tagged usdotfhwastol/carma-novatel-gps-driver:3.1.0 as usdotfhwastol/carma-novatel-gps-driver:```
### Steps to reproduce the behavior
Run `docker/build-image.sh`

### Related work

Link to related tickets or prior related work here.
maefromm commented 5 years ago

Additional missmatch of the names usdotfhwastol/carmaavtvimbadriver to usdotfhwastol/carma-avt-vimba-driver

maefromm commented 5 years ago

Additional mismatch of the names for Delphi esr and srr2 driver.

TonysCousin commented 4 years ago

Per John Baird, this has been resolved.