search

usdot-fhwa-stol / carma-platform

CARMA Platform is built on robot operating system (ROS) and utilizes open source software (OSS) that enables Cooperative Driving Automation (CDA) features to allow Automated Driving Systems to interact and cooperate with infrastructure and other vehicles through communication. Doxygen Source Code Documentation :
https://usdot-fhwa-stol.github.io/documentation/carma-platform/
400 stars 122 forks source link

SonarCloud Code Analysis for CARMAPlatform is below threshold #464

Open maefromm opened 4 years ago

maefromm commented 4 years ago

Types of Issue

Descriptive summary

During the testarossa build, SonarCloud check reported "Failed condition 35.9% Line Coverage on New Code (is less than 80%)".

As discussed with @Supraluminal , due to new build process for system integration testing of the testarossa release build onto DockerHub, we allowed this exception to the rule. Discussed that it shall be fixed on this issue and resolved prior to the final system release.

Related: "https://github.com/usdot-fhwa-stol/CARMAPlatform/pull/463

Expected behavior

All checks pass including circle ci build and sonar cloud checks.

Software version this applies to

testarossa

Actual behavior

See explanation above.

Steps to reproduce the behavior

Pull request failed for the merge from release to master branch for testarossa.

Related work

Link to related tickets or prior related work here.

TonysCousin commented 4 years ago

This is reporting a legitimate concern with unit test coverage, but there is no directly identifiable problem with the production code. Therefore, I'm removing the anomaly label. The condition should gradually improve with our newer development processes and as new code gets added with more unit tests.