usdot-fhwa-stol / carma-utils

Utility libraries for hardware drivers in the CARMA Platform

2 stars 5 forks source link

#190 Flip y-axis value in SemanticLidarSensor #191

Closed adamlm closed 10 months ago

adamlm commented 10 months ago

PR Details

Description

This PR patches an issue in CARLA 0.9.10 where the y-axis value for objects is flipped. Since CARMA uses CARLA 0.9.10, sensorlib flips the y-axis value to compensate for the error.

Related GitHub Issue

Closes #190 Replaces the (reverted) patch applied in usdot-fhwa-stol/carma-carla-integration#47

Related Jira Key

Closes CDAR-526

Motivation and Context

Instead of applying ad-hoc patches throughout CARMA, we decided it would be better to have only software the interfaces directly with CARMA be aware of the bug. This reduces the overhead when we can remove the patch. Instead of changing several places, we only need to change one (or a few).

How Has This Been Tested?

Types of changes

[x] Defect fix (non-breaking change that fixes an issue)
[x] Breaking change (fix or feature that cause existing functionality to change)

Checklist:

[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.

sonarcloud[bot] commented 10 months ago

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information

warning The version of Java (11.0.3) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17. Read more here