usdot-fhwa-stol / carma-utils

Utility libraries for hardware drivers in the CARMA Platform
2 stars 5 forks source link

Make `ros2_lifecycle_manager` package compatible with Humble #216

Closed adamlm closed 7 months ago

adamlm commented 7 months ago

PR Details

Description

This PR resolves issues that prevented the ros2_lifecycle_manager package from building on ROS 2 Humble. It removes the deprecated callback_group namespace that was removed between Foxy and Humble.

It also disambiguates the conversion function call when converting from a rclcpp::Client future type to its underlying std::shared_future. There was an API change between Foxy and Humble, but we have to rely on some of the deprecated implicit conversions until we can drop Foxy.

Related GitHub Issue

Related Jira Key

CF-793

Motivation and Context

Needed changes to get some necessary CARMA Platform packages to build on Humble.

How Has This Been Tested?

Compilation only

Types of changes

Checklist:

sonarcloud[bot] commented 7 months ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud