chengyuan0124 commented 1 year ago

PR Details

Description

This PR fixes the simulation freezing issue that occurs when NS3 and infrastructure ambassador are enabled and running in the MOSAIC scenario Tiergarten. The solution involved testing a simple Python script that sends a fake infrastructure registration JSON message to the infrastructure message receiver. The test confirmed that the infrastructure ambassador successfully registered RSU and DSRC to NS3 and stored the new registration in the infrastructureInstanceManager.

This screenshot is the log retrieving from MOSAIC-infrastructure ambassador:

Screenshot from 2023-04-20 03-53-16

Related Issue

Motivation and Context

How Has This Been Tested?

Types of changes

[x] Defect fix (non-breaking change that fixes an issue)
[ ] New feature (non-breaking change that adds functionality)
[ ] Breaking change (fix or feature that cause existing functionality to change)

Checklist:

[ ] I have added any new packages to the sonar-scanner.properties file
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have read the CONTRIBUTING document. CARMA Contributing Guide
[x] I have added tests to cover my changes.
[x] All new and existing tests passed.

kjrush commented 1 year ago

Also, took a look at the sonar scanner report. We can ignore the security issue they're talking about entirely, it's not an issue since it's not an actual-literal-real IP address, just a string representing an address within our simulated communications network.