usdot-fhwa-stol / cdasim

CDASim is an open-source simulation system supporting the development and testing of Cooperative Driving Automation applications.

37 stars 13 forks source link

Fix null pointer when infrastructure registration includes no sensor registrations #158

Closed paulbourelly999 closed 1 year ago

paulbourelly999 commented 1 year ago

PR Details

Description

InfrastructureMessageAmbassador throws nullpointer exception when infrastructure registration message includes no sensor registrations. This PR addresses that and addresses some sonar code smells about logger calls

Related Issue

Motivation and Context

Fix null pointer

How Has This Been Tested?

Types of changes

[x] Defect fix (non-breaking change that fixes an issue)
[ ] New feature (non-breaking change that adds functionality)
[ ] Breaking change (fix or feature that cause existing functionality to change)

Checklist:

[ ] I have added any new packages to the sonar-scanner.properties file
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document. CARMA Contributing Guide
[ ] I have added tests to cover my changes.
[x] All new and existing tests passed.

sonarcloud[bot] commented 1 year ago

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

87.5% Coverage
0.0% Duplication

warning The version of Java (11.0.20.1) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17. Read more here