kjrush commented 10 months ago

Scenarios will now be deployed from co-simulation/bundle/src/assembly/scenarios rather than from sample_scenarios.zip

PR Details

Description

Changes the docker build process to automatically deploy scenario files found in src/bundle/assembly/resources/scenarios instead of relying on a pre-zipped archive of scenario files.

Related GitHub Issue

Closes #175

Related Jira Key

Motivation and Context

This makes the behavior for adding a scenario more intuitive and lets us maintain scenarios as plain files instead of a zip archive.

How Has This Been Tested?

Ran locally after building fresh docker image and confirmed newly created test scenario files were deployed at /opt/carma-simulation/scenarios in the final image.

Types of changes

[ ] Defect fix (non-breaking change that fixes an issue)
[ ] New feature (non-breaking change that adds functionality)
[ ] Breaking change (fix or feature that cause existing functionality to change)

Checklist:

[x] I have added any new packages to the sonar-scanner.properties file
[ ] My change requires a change to the documentation.
[x] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes.
[x] All new and existing tests passed.

sonarcloud[bot] commented 10 months ago

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information

warning The version of Java (11.0.21) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17. Read more here

paulbourelly999 commented 9 months ago

Should this change impact VRU at all?

usdot-fhwa-stol / cdasim

Change location of scenarios that will be deployed in docker image. #177