usdot-fhwa-stol / cdasim

CDASim is an open-source simulation system supporting the development and testing of Cooperative Driving Automation applications.

38 stars 13 forks source link

CARMA Ambassador forwards time to CARMA Platform #186

Closed paulbourelly999 closed 9 months ago

paulbourelly999 commented 9 months ago

PR Details

Description

CARMA Ambassador now forwards time sync messages to CARMA Platform. This required

Making the TimeSync message class a generic class available to both CARMA and Infrastructure Ambassador by placing it in carma-utils
Adding unit test coverage for several classes in the carma-ambassador
Cleaning up code smells and incorrect documentation on methods involved in change set.

Related GitHub Issue

Related Jira Key

Motivation and Context

Get CARMA Platform to source ros time with CDA Sim time

How Has This Been Tested?

Unit testing

Types of changes

[x] Defect fix (non-breaking change that fixes an issue)
[ ] New feature (non-breaking change that adds functionality)
[ ] Breaking change (fix or feature that cause existing functionality to change)

Checklist:

[ ] I have added any new packages to the sonar-scanner.properties file
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes.
[x] All new and existing tests passed.

sonarcloud[bot] commented 9 months ago

Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

3 New issues
0 Security Hotspots
84.9% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud