usdot-fhwa-stol / cdasim

CDASim is an open-source simulation system supporting the development and testing of Cooperative Driving Automation applications.
38 stars 13 forks source link

Update docker build steps to allow for caching of dependencies #191

Closed paulbourelly999 closed 8 months ago

paulbourelly999 commented 8 months ago

PR Details

Description

Update docker build to allow for caching of installed dependencies. Currently rebuilding CDASim takes excessively long because the docker layer that pulls sumo and CARLA is the same one that builds mosiac. To improve on this I suggest we use scripts like install_dependencies.sh -> build.sh -> run.sh so that all dependencies can be installed in a single build layer and cached and changes to source code should not trigger dependencies to be downloaded again and rebuilt. This PR only includes the addition of an "install_dependencies.sh" and a "build.sh". There already exists a run script called mosaic.sh. There may be some reorganization necessary to allow the added scripts directory to coexist with the docker directory. Would suggest further improvements for moving install scripts out of docker directory and uncoupling them from docker deployment. In the future, the docker director should only including things in this directory that are specific to docker like tagging scripts.

Related GitHub Issue

Related Jira Key

CDAR-719

Motivation and Context

Quicker builds

How Has This Been Tested?

CI

Types of changes

Checklist:

paulbourelly999 commented 8 months ago

@adamlm Created the following issue for us to house some of your installation process improvements (https://github.com/usdot-fhwa-stol/cdasim/issues/194). Depending on the scope we can create more issues.

sonarcloud[bot] commented 8 months ago

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud