kruegersp commented 7 months ago

PR Details

Description

This PR primarily focuses on merging a branch into develop, which encompasses the integration testing of CARMA Cloud with CDASim. The purpose of this integration test was to assess the communication between CARMA Cloud and CDASim, ensuring that:

All components operate correctly within CDASim without encountering any significant problems. CARMA Cloud successfully registers with Ambassador. CARMA Cloud receives and processes time synchronization messages.

Related GitHub Issue

Related Jira Key

CXC-10

Motivation and Context

How Has This Been Tested?

Types of changes

[ ] Defect fix (non-breaking change that fixes an issue)
[x] New feature (non-breaking change that adds functionality)
[ ] Breaking change (fix or feature that cause existing functionality to change)

Checklist:

[ ] I have added any new packages to the sonar-scanner.properties file
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.

sonarcloud[bot] commented 6 months ago

Quality Gate failed

Failed conditions
8.4% Duplication on New Code (required ≤ 3%)
31.4% Line Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

paulbourelly999 commented 6 months ago

Please break this PR into smaller independent pieces of functionality like :

CARMA Cloud Ambassador
Sumo scenario configuration
CARLA Scenario configuration

Also lets not create a 3rd Town04 CDASim scenario that is just a copy of the others. It would require unnecessary maintenance of three separate scenarios.

paulbourelly999 commented 6 months ago

@kruegersp Please address code smells, duplication and code coverage from sonar scan report.

sonarcloud[bot] commented 4 months ago