MishkaMN commented 6 months ago

PR Details

Description

Adds logs to support https://github.com/usdot-fhwa-stol/carma-analytics-fotda/pull/43

Related GitHub Issue

Related Jira Key

CDAR-774

Motivation and Context

Data Analysis

How Has This Been Tested?

Types of changes

[ ] Defect fix (non-breaking change that fixes an issue)
[ ] New feature (non-breaking change that adds functionality)
[ ] Breaking change (fix or feature that cause existing functionality to change)

Checklist:

[ ] I have added any new packages to the sonar-scanner.properties file
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.

paulbourelly999 commented 6 months ago

Address code smells.

MishkaMN commented 6 months ago

Confirmed that this works. I enabled DEBUG in logback.xml to get this:

2024-03-21 16:00:54,428 INFO  CarmaV2xMessageReceiver:78 - CarmaV2xMessageReceiver started listening on UDP port: 1517.
2024-03-21 16:00:54,429 INFO  CarmaV2xMessageReceiver:78 - CarmaV2xMessageReceiver started listening on UDP port: 1516.
2024-03-21 16:00:54,446 DEBUG SequentialTimeManagement:103 - Simulation Time: 0 where current system time is: 1711036854446 and requested from id: mapping
2024-03-21 16:00:54,447 INFO  AbstractTimeManagement:231 - Simulating: 0ns (0.0s / 600.0s) - 0.0% (RTF:0.00, ETC:unknown)                        
2024-03-21 16:00:54,447 DEBUG SequentialTimeManagement:103 - Simulation Time: 0 where current system time is: 1711036854447 and requested from id: sumo
2024-03-21 16:01:11,883 INFO  AbstractTimeManagement:231 - Simulating: 0ns (0.0s / 600.0s) - 0.0% (RTF:0.00, ETC:unknown)                        
2024-03-21 16:01:11,891 DEBUG SequentialTimeManagement:103 - Simulation Time: 0 where current system time is: 1711036871891 and requested from id: ns3
2024-03-21 16:01:11,901 DEBUG SequentialTimeManagement:103 - Simulation Time: 0 where current system time is: 1711036871901 and requested from id: carla
2024-03-21 16:01:12,383 INFO  AbstractTimeManagement:231 - Simulating: 0ns (0.0s / 600.0s) - 0.0% (RTF:0.00, ETC:unknown)                        
2024-03-21 16:01:12,883 INFO  AbstractTimeManagement:231 - Simulating: 0ns (0.0s / 600.0s) - 0.0% (RTF:0.00, ETC:unknown)                        
2024-03-21 16:01:13,383 INFO  AbstractTimeManagement:231 - Simulating: 0ns (0.0s / 600.0s) - 0.0% (RTF:0.00, ETC:unknown)                        
2024-03-21 16:01:13,666 DEBUG SequentialTimeManagement:103 - Simulation Time: 0 where current system time is: 1711036873666 and requested from id: carma
2024-03-21 16:01:13,722 DEBUG SequentialTimeManagement:103 - Simulation Time: 0 where current system time is: 1711036873722 and requested from id: infrastructure
2024-03-21 16:01:13,722 DEBUG SequentialTimeManagement:103 - Simulation Time: 0 where current system time is: 1711036873722 and requested from id: application
2024-03-21 16:01:13,723 DEBUG SequentialTimeManagement:103 - Simulation Time: 0 where current system time is: 1711036873723 and requested from id: ns3
2024-03-21 16:01:13,723 DEBUG SequentialTimeManagement:103 - Simulation Time: 1 where current system time is: 1711036873723 and requested from id: ns3
2024-03-21 16:01:13,724 DEBUG SequentialTimeManagement:103 - Simulation Time: 1 where current system time is: 1711036873724 and requested from id: ns3
2024-03-21 16:01:13,724 DEBUG SequentialTimeManagement:103 - Simulation Time: 2 where current system time is: 1711036873724 and requested from id: ns3
2024-03-21 16:01:13,724 DEBUG SequentialTimeManagement:103 - Simulation Time: 2 where current system time is: 1711036873724 and requested from id: ns3
2024-03-21 16:01:13,724 DEBUG SequentialTimeManagement:103 - Simulation Time: 3 where current system time is: 1711036873724 and requested from id: ns3
2024-03-21 16:01:13,725 DEBUG SequentialTimeManagement:103 - Simulation Time: 3 where current system time is: 1711036873725 and requested from id: ns3
2024-03-21 16:01:13,725 DEBUG SequentialTimeManagement:103 - Simulation Time: 4 where current system time is: 1711036873725 and requested from id: ns3
2024-03-21 16:01:13,725 DEBUG SequentialTimeManagement:103 - Simulation Time: 4 where current system time is: 1711036873725 and requested from id: ns3

sonarcloud[bot] commented 6 months ago

Quality Gate failed

Failed conditions
78.57% Line Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

usdot-fhwa-stol / cdasim

Feature/add time sync logs #205