usdot-fhwa-stol / cdasim

CDASim is an open-source simulation system supporting the development and testing of Cooperative Driving Automation applications.

38 stars 13 forks source link

Remove debug flag requirement for time sync script log for sumo #210

Closed MishkaMN closed 5 months ago

MishkaMN commented 5 months ago

PR Details

Description

Previous PR here https://github.com/usdot-fhwa-stol/cdasim/pull/205 merged a log statement line that the time sync script relies on (https://github.com/usdot-fhwa-stol/carma-analytics-fotda/pull/43).

However, it had a typo, which this PR fixes.
This PR also removes the debug log requirement for this line change because one simulation run log from this same class could easily be 500MB. Time sync script is working too much to parse every single line and is having adverse effect. Since the line is just a log statement, it is safe to leave it in there without DEBUG option and its size goes up to 500kb or so

vs

Related GitHub Issue

https://github.com/usdot-fhwa-stol/cdasim/issues/209

Related Jira Key

https://usdot-carma.atlassian.net/browse/CDAR-662 https://usdot-carma.atlassian.net/browse/CDAR-774

Motivation and Context

VRU verification testing

How Has This Been Tested?

sim pc 1

Types of changes

[X] Defect fix (non-breaking change that fixes an issue)
[ ] New feature (non-breaking change that adds functionality)
[ ] Breaking change (fix or feature that cause existing functionality to change)

Checklist:

[X] I have added any new packages to the sonar-scanner.properties file
[X] My change requires a change to the documentation.
[X] I have updated the documentation accordingly.
[X] I have read the CONTRIBUTING document.
[X] I have added tests to cover my changes.
[X] All new and existing tests passed.

sonarcloud[bot] commented 5 months ago

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
66.7% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud