usdot-fhwa-stol / cdasim

CDASim is an open-source simulation system supporting the development and testing of Cooperative Driving Automation applications.
37 stars 13 forks source link

Cxc 91 update pose transform lib #227

Closed adev4a closed 1 month ago

adev4a commented 1 month ago

PR Details

This PR adds pose transformation in mosaic using Proj. During testing it was found that the map transform calculated by mosaic on the data subscribed to from Traci, does not have geodetic coordinates that match the values calculated by carma-platform. In order to fix this, the transform library in mosaic was extended to accept another parameter for the georeference string which can be used to calculate the geodetic coordinates like it is being calculated in carma-platform and sumo natively (Using proj).

The added georeference field is an optional argument to the mosaic scenario_configuration.

Description

Related GitHub Issue

Related Jira Key

https://usdot-carma.atlassian.net/browse/CXC-91

Motivation and Context

How Has This Been Tested?

Integration tested on xil_carma_cloud scenario on develop and vru scenario on carma-system-4.5.0.

Types of changes

Checklist:

sonarcloud[bot] commented 1 month ago

Quality Gate Failed Quality Gate failed

Failed conditions
8.0% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

adev4a commented 1 month ago

Looks like code coverage is >80%. Line duplication requirements are currently not met, the duplicated lines are required definitions of pure virtual functions and the warning should be safe to ignore.