Feature/carma messenger ambassador

[EricChen-Lei]

PR Details

Description

Implement carma messenger ambassador

Related GitHub Issue

Related Jira Key

CXC-88

Motivation and Context

How Has This Been Tested?

Types of changes

• [ ] Defect fix (non-breaking change that fixes an issue)
• [x] New feature (non-breaking change that adds functionality)
• [ ] Breaking change (fix or feature that cause existing functionality to change)

Checklist:

• [ ] I have added any new packages to the sonar-scanner.properties file
• [ ] My change requires a change to the documentation.
• [ ] I have updated the documentation accordingly.
• [ ] I have read the CONTRIBUTING document.
• [ ] I have added tests to cover my changes.
• [ ] All new and existing tests passed.

[kjrush]

I'm a bit concerned about the amount of duplication in this one, it looks like a lot of this is the same as the CARMA Platform ambassador, which is fine and expected. But rather than simply duplicating the code, we should be looking at how to refactor it to minimize duplication. Can we inherit directly from the CARMAPlatformAmbassador class and override the specific functions we need to change to support messenger? Are there parts of the CARMA Platform Ambassador that should be refactored out into a base-class that both Platform and Messenger ambassadors inherit from? Should some of the existing classes just be renamed and reused as-is instead of duplicated?

[sonarcloud[bot]]

Quality Gate failed

Failed conditions
48.05% Line Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud