Closed DeraldDudley closed 4 years ago
~There are a few issues with the specific implementation of this PR. Mainly, in road_events.md
the entire table is rewritten and loses its formatting (bold pieces, code, hyperlinks, etc) even though just one property is added. Additionally, the examples and schema need to be updated to reflect the addition of the type field and corresponding enumeration.~
Edit: all resolved; see below.
Updated the examples and schema.
Edit: re-implemented the type field addition to fix the table formatting and diff as well
@DeraldDudley what do you think about naming the new field event_type
rather than just type
. Though largely just style, I was thinking it felt a bit more clear, and is consistent with the event_status
property already on the road event.
Updated field from type
to event_type
and the enum from "road event type" to "event type" for consistency with event_status
field and "event status" enum.
@DeraldDudley what do you think about naming the new field
event_type
rather than justtype
. Though largely just style, I was thinking it felt a bit more clear, and is consistent with theevent_status
property already on the road event.
I agree. No objections here.
Include Detour Information for a Road Event
Reference Issue #82
GeoJSON detour example: https://gist.github.com/DeraldDudley/d5a1d9e5a6dd3add5f7a1b9d007a5c2c
1. Updated road_events table to add a single new field.
2. Added a new enumerated type
Event Type Enumeration