usdot-jpo-ode / wzdx

The Work Zone Data Exchange (WZDx) Specification aims to make harmonized work zone data provided by infrastructure owners and operators (IOOs) available for third party use, making travel on public roads safer and more efficient through ubiquitous access to data on work zone activity.
Creative Commons Zero v1.0 Universal
89 stars 62 forks source link

Refactor RoadEvent beginning and ending accuracy #213

Closed j-d-b closed 2 years ago

j-d-b commented 2 years ago

This issue is regarding refactoring the beginning_accuracy and ending_accuracy properties on the RoadEvent for clarity.

I originally proposed this idea in https://github.com/usdot-jpo-ode/wzdx/pull/199#issuecomment-907206410 and moved it to and issue as it is separate enough from #199 to be discussed separately.

The proposed changes simplify the specification without losing functionality (which is my goal—make WZDx easy to use and understand while still being powerful).

Proposed Changes

Pros

is_begin_location_verified and is_end_location_verified must only be true when the location is based on actual reported data from a GPS equipped device showing the measured location of the work zone

Cons

j-d-b commented 2 years ago

The fact this is a breaking change and just "cleanup" almost led me to not post this issue. However I thought it should be recorded for when there is a time where we are making breaking changes and/or other changes that may affect this property/concept. Then, it could be a good thing to implement.

natedeshmukhtowery commented 2 years ago

Thanks for recording this for future discussion. I think the proposal is logical, but I would definitely like to hear from other state and local agencies working to produce WZDx feeds for their thoughts both on the proposed approach as well as on implementation. Thanks!

j-d-b commented 2 years ago

There were no additional options for accuracy brought up at the Spec Update Subgroup meeting, so we can move forward with the boolean refactor.

j-d-b commented 2 years ago

Resolved in #281.