Closed j-d-b closed 2 years ago
The fact this is a breaking change and just "cleanup" almost led me to not post this issue. However I thought it should be recorded for when there is a time where we are making breaking changes and/or other changes that may affect this property/concept. Then, it could be a good thing to implement.
Thanks for recording this for future discussion. I think the proposal is logical, but I would definitely like to hear from other state and local agencies working to produce WZDx feeds for their thoughts both on the proposed approach as well as on implementation. Thanks!
There were no additional options for accuracy brought up at the Spec Update Subgroup meeting, so we can move forward with the boolean refactor.
Resolved in #281.
This issue is regarding refactoring the
beginning_accuracy
andending_accuracy
properties on the RoadEvent for clarity.I originally proposed this idea in https://github.com/usdot-jpo-ode/wzdx/pull/199#issuecomment-907206410 and moved it to and issue as it is separate enough from #199 to be discussed separately.
The proposed changes simplify the specification without losing functionality (which is my goal—make WZDx easy to use and understand while still being powerful).
Proposed Changes
location_verify_method
(which is proposed in #199)beginning_accuracy
andending_accuracy
properties (which use the SpatialVerification enumerated type) from the RoadEvent object.is_begin_location_verified
andis_end_location_verified
to the RoadEvent which have boolean values indicating whether or not the begin/end is verified (if it's not verified, it's estimated, so we don't need an enumerated type if there are only two options).Pros
is_begin_location_verified
is more clear what the property is describing thanbeginning_accuracy
, which doesn't indicate by name that it's for the location (we could name itis_start_point_verified
to be more clear, because that's what the property is specifically describing).is_begin_location_verified
could be:Cons
estimated
andverified
for describing the accuracy of the start/end