usdot-jpo-ode / wzdx

The Work Zone Data Exchange (WZDx) Specification aims to make harmonized work zone data provided by infrastructure owners and operators (IOOs) available for third party use, making travel on public roads safer and more efficient through ubiquitous access to data on work zone activity.
Creative Commons Zero v1.0 Universal
92 stars 62 forks source link

Update Examples for 4.2 #339

Closed sknick-iastate closed 1 year ago

sknick-iastate commented 2 years ago

This pull request updates the examples to represent the changes made for WZDx 4.2. This includes updating both the work zone and device examples.

In addition to updating the examples the following changes were made to the organization of the examples:

sknick-iastate commented 2 years ago

@j-d-b and @mark-mockett - The examples should be up to date with main now after the 4.1 release

j-d-b commented 1 year ago

Per co-chairs discussion 2022-12-13, local access only can be renamed "scenario 8" for consistency.

mark-mockett commented 1 year ago

I believe there are a few duplicated images in the images folder:

sknick-iastate commented 1 year ago

I believe there are a few duplicated images in the images folder:

  • "complex_work_zone_with_ramp.png" and it's annotated version are duplicates of "sign_method.png" and its annotated verion
  • "mainline_ramp_merging_lane_closure.png" and its annotated version are duplicates of "sign_method_simple.png" and its annotated version

Resolved. I removed the extra images and made sure we had at least one from each of the original examples.

sknick-iastate commented 1 year ago

Left individual comments along the way, but I noted a few items that should be updated:

  • [ ] Update image for Example 2 to show only one road event with lanes 1 and 5 closed and lanes 2-4 shifted right
  • [ ] Fix typos in descriptions of scenario 7
  • [ ] Update feed-level dates in scenario 7 file
  • [ ] Update versions of all scenarios to 4.2

@sknick-iastate let me know if you'd like me to commit any of these changes once you've seen the suggestions!

Thanks Mark! Sorry I went through making the changes and just now seeing this comment. I have everything updated now as you suggested. The only additional change I made was some different formatting on the example 2 annotated image and indicating that lane 5 was previously the shoulder.

j-d-b commented 1 year ago

Sorry for the delay here, thank you @sknick-iastate for creating this PR.