search

usdot-jpo-ode / wzdx

The Work Zone Data Exchange (WZDx) Specification aims to make harmonized work zone data provided by infrastructure owners and operators (IOOs) available for third party use, making travel on public roads safer and more efficient through ubiquitous access to data on work zone activity.
Creative Commons Zero v1.0 Universal
89 stars 62 forks source link

Fix chevron enums in 4.1 and 4.2 schemas #366

Closed mark-mockett closed 1 year ago

mark-mockett commented 1 year ago

Closes #365

Proposed Changes

Change DeviceFeed schema TrafficSignalMode enumberations starting right-chevrons- to right-chevron-

This issue was previously resolved for the v4.0 schema in #307 but the change was not carried over to the new v4.1 schema or v4.2 schema

j-d-b commented 1 year ago

I think this was actually supposed to be plural for both based on the original source of these. I'll look for the issue with that discussion.

Also, this is technically a breaking change.

Edit: it is, but unlikely to break anything and more is just matching our documentation, so not a big deal.

mark-mockett commented 1 year ago

@j-d-b I found the original DeviceFeed issue (#195) and even there it's inconsistent between left-chevron and right-chevrons. I think singular was the right choice (and the arrow enums are also singular).

I'll merge this afternoon unless anyone has anything to finish discussing.

Dunge commented 1 year ago

Good catch! Our implementation used the singular values from the documentation, so I approve this pull request for uniformity it singular everywhere.

j-d-b commented 1 year ago

Ok, I'm fine with merging due to the schema matching the documentation and other's comments.