search

usdot-jpo-ode / wzdx

The Work Zone Data Exchange (WZDx) Specification aims to make harmonized work zone data provided by infrastructure owners and operators (IOOs) available for third party use, making travel on public roads safer and more efficient through ubiquitous access to data on work zone activity.
Creative Commons Zero v1.0 Universal
91 stars 62 forks source link

Restore deleted sign_method image #369

Closed mtfurlan closed 11 months ago

mtfurlan commented 1 year ago

This image is still used by spec-content/enumerated-types/LocationMethod.md

It was deleted in 42b98fcdd837e897ae3e208780c45ce61f7fc12a, and I'm assuming this was a mistake because it's still referenced.

sknick-iastate commented 1 year ago

I think the image was removed/renamed as part of the example images clean up. A similar image below already exists and has the naming convention we were using for the example scenarios (as well as potential future examples referenced in the discussion).

https://github.com/usdot-jpo-ode/wzdx/blob/main/images/complex_work_zone_with_ramp.png

There are some differences in the the previous image which also included the begin/end location reference based on where the signs were placed. I'm good with just adding the image back but wanted to give some context in why it was potentially removed.

mtfurlan commented 1 year ago

I'm fine modifying https://github.com/usdot-jpo-ode/wzdx/blob/main/spec-content/enumerated-types/LocationMethod.md to use that image, the broken link gets fixed either way. Let me know if you want me to change it.

j-d-b commented 11 months ago

I think having the separate image file for the sign-method location method is consistent with that there are specific images for the other location method options, so I support merging this PR.

sknick-iastate commented 11 months ago

That sounds good to me. Thanks!