search

usds / justice40-tool

A tool to identify disadvantaged communities due to environmental, socioeconomic and health burdens
https://screeningtool.geoplatform.gov/
Creative Commons Zero v1.0 Universal
125 stars 42 forks source link

remove release banner #2186

Closed vim-usds closed 1 year ago

vim-usds commented 1 year ago
github-actions[bot] commented 1 year ago

🚢 Here is the frontend staging link: 🚢
Find it here: https://screeningtool-staging.geoplatform.gov/2186-208175/en/ !

vim-usds commented 1 year ago

Approved, with a minor nit – feel free to address or ignore: why just comment out the Alert, and not remove it? We could always go back in history and retrieve it if we need to.

This is a valid point. I go back and forth on this. I believe I did remove this in the past, and then forgot which file had Alert (as it could in the Header or Layout). I started re-implementing it (this might be because I may not know how to search the history effectively). I then decided that for things like an Alert (which is often brought in and out) commented out allows me to quickly find and make the change.

Out of curiosity, is searching for this change easy to do if one doesn't know the file name that made the change?

travis-newby commented 1 year ago

That makes more sense for something that comes and goes frequently. And you're right, git history search stinks.

github-actions[bot] commented 1 year ago

🚢 PR Deployed! 🚢 Find it here: https://screeningtool.geoplatform.gov !