Closed fatima-gov closed 6 years ago
Feedback from me:
Clarify the difference between imported files coming from the lib/
directory and the original source files from src/
, which are probably more readable, and are what we link to throughout our documentation.
Make more clear in the docs on schema
and uiSchema
how both are used. There was some confusion in the description of how uiSchema
was developed by rjsf if that meant that rjsf only uses uiSchmea
and not the regular schema
. Make clear that both are used by rjsf, and by consequence, our library, and that they serve different purposes.
The Quick Start form.js
is more of an "every feature in the system" example. We need a simple progression example that shows a true simple config file.
In definitions like https://github.com/usds/us-forms-system/blob/master/docs/building-a-form/common-definitions.md#phone you actually also need corresponding schema
definitions to match up with the uiSchema
defined here. In this case, the uiSchema
defines an error message that must be defined the schema
so that it gives a correct error message. This is most likely true of several others.
Include guidance on where chunks of uiSchema
and schema
live. Definitions are part of that, but perhaps there's more information we can include about this.
Make available components highly visible and easily browsable. Right now it's kind of difficult to know what components are available and what they do and look like. Could be something similar to how USWDS inventories their components, with left navigation and lots of visuals and code samples.
Getting started docs are too complicated, wasn't sure where to look first and was overwhelmed by information.
Beef up instructions on incorporating library into existing repo.
Unclear how 'ui:errorMessages' property matches the schema properties (e.g., pattern, minLength, etc.).
Create docs on how the review page works.
For fields that only had schema
and not uiSchema
, those fields didn't show up on the review page.
Consider combining schema
and uiSchema
.
Tools to link or check the validity of your form config would be really useful. (See #176)
More examples and more visuals in the documentation would be helpful.
Would like to see more information about how US Forms could be integrated into existing applications/frameworks
Information about validators was hard to find in jsonSchema (not listed in contents; had to find it under "type-specific keywords")
@fatima-gov If everything in here is in its appropriate tickets and what not, let's close. Thanks!
US Forms Hackathon Information
Thanks for participating in the first US Forms Hackathon! Here’s some information about the event:
Find a team! We'd like you to pair up.
Install the starter app and set up your repo: (https://github.com/usds/us-forms-system/blob/master/docs/getting-started/creating-a-new-application-with-the-us-forms-system-starter-app.md) a. Use a new public repo under your username. b. In the repo description, add the name of the form you're building. c. Start building your form!
Challenge Part 1 | Warm up: Build USCIS Form G-1145
Challenge Part 2 | Main event: Choose one of the two below forms to build.
Demos and feedback start at 7:00. Please be prepared to: