usds / us-forms-system

Build React forms with JSON Schema and the U.S. Web Design System
Other
140 stars 34 forks source link

Update to uswds v2 #359

Open humancompanion-usds opened 4 years ago

humancompanion-usds commented 4 years ago

Updates US Forms System to USWDS v2.

Types of changes

Updates to the scss and React components.

Checklist:

Working on tests and looking into documentation changes, if any.

dmethvin-gov commented 4 years ago

@humancompanion-usds Sorry about the delay. The build is failing because there is an issue with the dependencies, not with your changes. (Or at least, whatever problems your changes introduce aren't being encountered yet!) I need to fix them (which I've done locally) and publish a new release of both the library and the starter app. You'd think that would be simple but the build process is rather manual and it has bit-rotted some as well. I also have to find all the correct authentication stuff so that I can publish. Both of those are more complicated than they have to be because they have things so locked down.

In the meantime you might be able to get unblocked by making the following changes to the package.json in your starter app repo. I at least got it to build with this.

index 39cb8f3..18bcfde 100644
--- a/package.json
+++ b/package.json
@@ -27,10 +27,10 @@
     "css-loader": "^2.1.1",
     "eslint": "^4.19.1",
     "eslint-config-airbnb": "^15.1.0",
-    "eslint-plugin-import": "^2.16.0",
+    "eslint-plugin-import": "^2.22.0",
     "eslint-plugin-jsx-a11y": "^5.1.1",
     "eslint-plugin-no-unsafe-innerhtml": "^1.0.14",
-    "eslint-plugin-react": "^7.12.4",
+    "eslint-plugin-react": "^7.20.6",
     "eslint-plugin-scanjs-rules": "^0.1.4",
     "eslint-stats": "^1.0.0",
     "mocha": "^5.2.0",
@@ -40,17 +40,21 @@
     "svg-url-loader": "^2.3.2",
     "uglifyjs-webpack-plugin": "^2.1.2",
     "url-loader": "^1.0.1",
-    "webpack": "^4.29.6",
-    "webpack-bundle-analyzer": "^3.3.2",
-    "webpack-cli": "^3.2.3",
-    "webpack-dev-server": "^3.2.1",
+    "webpack": "^4.44.1",
+    "webpack-bundle-analyzer": "^3.8.0",
+    "webpack-cli": "^3.3.12",
+    "webpack-dev-server": "^3.11.0",
     "webpack-merge": "^4.2.1"
   },
   "dependencies": {
+    "history": "3",
+    "react-redux": "4.4.8",
+    "redux": "^3.5.2",
+    "react-router": "^3.2.6",
     "prop-types": "^15.7.2",
     "react": "^15.6.2",
     "react-dom": "^15.6.2",
-    "us-forms-system": "^1.1.0",
-    "uswds": "^1.6.3"
+    "us-forms-system": "file:../us-forms-system",
+    "uswds": "^2.8.1"
   }