use-ink / contracts-ui

Web application for deploying wasm smart contracts on Substrate chains that include the FRAME contracts pallet
https://contracts-ui.substrate.io/
GNU General Public License v3.0
62 stars 47 forks source link

[WIP] First attempt #364

Closed gabrielfior closed 1 year ago

gabrielfior commented 1 year ago

As described in this issue, the idea was to allow the user to specify a custom (valid) RPC endpoint. My approach involved the following parts: [ X ] Add components to handle user interaction (input, button) [X ] Handle network Options (all RPC endpoints - i.e. Shibuya, local node, etc) in a centralized way using the ApiContextProvider [ 1/2 X] Make the NetworkAndUser dropdown identify the custom node and accept it.

What is missing:

netlify[bot] commented 1 year ago

Deploy Preview for contracts-ui failed.

Name Link
Latest commit 66d64a1612e73d7d46495393fbff16465cc35e2d
Latest deploy log https://app.netlify.com/sites/contracts-ui/deploys/63243c751db9e8000875cc4e
cla-bot-2021[bot] commented 1 year ago

User @gabrielfior, please sign the CLA here.

gabrielfior commented 1 year ago

Regarding code review, no major points to add. However, I would imagine the user might want to specify multiple local nodes (occurs with me when using Hardhat for different forks), so it might be worth considering not updating the Local Node network definition every time and istead allowing for multiple configs.

gabrielfior commented 1 year ago

@statictype