search

use-ink / contracts-ui

Web application for deploying wasm smart contracts on Substrate chains that include the FRAME contracts pallet
https://contracts-ui.substrate.io/
GNU General Public License v3.0
61 stars 45 forks source link

Layout: Order of buttons should be switched #418

Closed cmichi closed 1 year ago

cmichi commented 1 year ago

The "Go Back" button should be on the left, the "Next" on the right.

It happens here:

image

But also on other pages.

statictype commented 1 year ago

it think it's a feature, but good idea! 🙂

Raghav-Programmer commented 1 year ago

@cmichi I can help solve this issue. plz assign this to me.

Raghav-Programmer commented 1 year ago

Can u help me to find the code file for this issue.

peetzweg commented 1 year ago

Can u help me to find the code file for this issue.

Hi @Raghav-Programmer! Thanks for tackling this issue. There seems to be two places where the placement of the buttons needs to be switched. One is in Step2.tsx and the other in Step3.tsx. See detailed lines below. Hope this helps.

I used the search function of GitHub to search the Repository of the occurrences of Go Back. VSCode also has a function to search across all workspace files, it's super handy in an unfamiliar codebase. :)

Step2.tsx: https://github.com/paritytech/contracts-ui/blob/cc94fbb07e5c3421ac14cb95f41dd61ca57480aa/src/ui/components/instantiate/Step2.tsx#L185-L212

Step3.tsx: https://github.com/paritytech/contracts-ui/blob/cc94fbb07e5c3421ac14cb95f41dd61ca57480aa/src/ui/components/instantiate/Step3.tsx#L91-L112

peetzweg commented 1 year ago

Removing assignment of this ticket as no progress has been made until now.