use-ink / contracts-ui

Web application for deploying wasm smart contracts on Substrate chains that include the FRAME contracts pallet
https://contracts-ui.substrate.io/
GNU General Public License v3.0
61 stars 44 forks source link

feat: list testnet faucets #467

Closed peetzweg closed 1 year ago

peetzweg commented 1 year ago

Closes #460

Added an md file with a list of recent testnet faucets and reference it in these error messages.

This error message is a bit hard to get, it's only visible if you have a valid wallet extension but not created an account yet. I think we should add it somewhere else as well. See below:

Screenshot 2023-04-19 at 11 56 59 Screenshot 2023-04-19 at 12 10 10

How about we add a list of useful links, like to the faucet md file, right here:

Screenshot 2023-04-17 at 11 16 41
netlify[bot] commented 1 year ago

Deploy Preview for contracts-ui ready!

Name Link
Latest commit 9ca3016d0c7c8d9b95a14494e8f5dfce30189f3d
Latest deploy log https://app.netlify.com/sites/contracts-ui/deploys/6464ca1c52a6a00008cc0b99
Deploy Preview https://deploy-preview-467--contracts-ui.netlify.app/
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

statictype commented 1 year ago

How about we add a list of useful links...

How about we link to it in the "Help & Feedback" modal?

Screenshot 2023-05-08 at 18 47 25
peetzweg commented 1 year ago

How about we link to it in the "Help & Feedback" modal?

Yes for sure the simplest solution. Just added it. Not as visible but can't hurt imho.

SCR-20230509-jlbd

Regarding the link to the faucet in the <Statistics/> component. I think it should be a link to the faucet directly instead of the link to the FAUCETS.md file. Let me know if we want to add this or if the link in the help modal is good all we want. :)

https://github.com/paritytech/contracts-ui/blob/66a276e314ee5c2da85277b7a3eaed7a9667f9aa/src/ui/components/homepage/Statistics.tsx#L36-L41

statictype commented 1 year ago

I think the modal is good for now. We could also link to the new page in the project README.

peetzweg commented 1 year ago

Good points! Adapted the icon and added a reference to it in the README file.

Screenshot 2023-05-09 at 11 07 17 Screenshot 2023-05-09 at 11 07 10
statictype commented 1 year ago

please resolve conflicts so we can merge this!

peetzweg commented 1 year ago

please resolve conflicts so we can merge this!

@statictype done, please reapprove. 👍

Btw do we know now whats wrong with the cypress test in ci? Locally they run just fine.