search

use-ink / contracts-ui

Web application for deploying wasm smart contracts on Substrate chains that include the FRAME contracts pallet
https://contracts-ui.substrate.io/
GNU General Public License v3.0
61 stars 44 forks source link

fix: duplicated keys #502

Closed gaboesquivel closed 11 months ago

gaboesquivel commented 11 months ago

fixes error reported in #447

using the array index in the key string should work fine long the events list is not rearranged. if that were the case, then using random ids would be better, its suboptimal for performance as it causes renders but we wont have unexpected behavior.

netlify[bot] commented 11 months ago

Deploy Preview for contracts-ui ready!

Name Link
Latest commit df8a8007b3301d76890c7f71e4288a1e2a77dfc6
Latest deploy log https://app.netlify.com/sites/contracts-ui/deploys/64bfc7ac0b78aa0008a88646
Deploy Preview https://deploy-preview-502--contracts-ui.netlify.app/
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

cypress[bot] commented 11 months ago

Passing run #163 ↗︎

0 61 0 0 Flakiness 0
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.

Details:

fix: duplicated keys
Project: Contracts UI Commit: df8a8007b3
Status: Passed Duration: 02:38 💡
Started: Jul 25, 2023 1:01 PM Ended: Jul 25, 2023 1:04 PM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.