search

use-ink / contracts-ui

Web application for deploying wasm smart contracts on Substrate chains that include the FRAME contracts pallet
https://contracts-ui.substrate.io/
GNU General Public License v3.0
61 stars 44 forks source link

fix: prevents turning falsy values into `null` #525

Closed peetzweg closed 7 months ago

peetzweg commented 7 months ago

Resolves #517.

This function turned every js falsy value, like false, "", 0 into null, thereby preventing passing these actual values as inputs to contract calls.

https://github.com/paritytech/contracts-ui/blob/2387223e1c9d5b0430831141862afea0e834382b/src/lib/callOptions.ts#L56-L70

netlify[bot] commented 7 months ago

Deploy Preview for contracts-ui ready!

Name Link
Latest commit 2387223e1c9d5b0430831141862afea0e834382b
Latest deploy log https://app.netlify.com/sites/contracts-ui/deploys/655795849d14040008ee9940
Deploy Preview https://deploy-preview-525--contracts-ui.netlify.app/
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

cypress[bot] commented 7 months ago

Passing run #256 ↗︎

0 61 0 0 Flakiness 0
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.

Details:

don't evaluate "falsy" values to `null`
Project: Contracts UI Commit: 2387223e1c
Status: Passed Duration: 01:58 💡
Started: Nov 17, 2023 4:32 PM Ended: Nov 17, 2023 4:34 PM

Review all test suite changes for PR #525 ↗︎