Closed peetzweg closed 2 months ago
Name | Link |
---|---|
Latest commit | 1a6b445af17c6597141b5cb6d77cb3e55fed9eba |
Latest deploy log | https://app.netlify.com/sites/contracts-ui/deploys/6615341c5c48bd0008869af1 |
Deploy Preview | https://deploy-preview-553--contracts-ui.netlify.app |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
![]() |
![]() |
![]() |
![]() |
![]() |
Details:
Merge 1a6b445af17c6597141b5cb6d77cb3e55fed9eba into faac63dabb4f5562c299d4837e92... | |||
Project: Contracts UI | Commit: f3ab6cdb4e âšī¸ |
||
Status: Passed | Duration: 01:13 đĄ | ||
Started: Apr 9, 2024 12:29 PM | Ended: Apr 9, 2024 12:30 PM |
![]() |
![]() |
![]() |
![]() |
![]() |
â ī¸ You've recorded test results over your free plan limit. Upgrade your plan to view test results. |
Details:
fix: removes unecessary encoding of salt during dryrun (#553) | |||
Project: Contracts UI | Commit: f1d8c8ee14 |
||
Status: Passed | Duration: 01:19 đĄ | ||
Started: Apr 11, 2024 8:29 AM | Ended: Apr 11, 2024 8:30 AM |
Closes #382.
The ui was encoding the salt during dryrunning the instantiate of contracts but not during the actual instantiation. Therefore the contract address shown from the dry run result was not matching the actual deployed contract address.
Video showing the bug before and after fix:
https://github.com/paritytech/contracts-ui/assets/839848/5a5b9b7b-a0b6-4697-883f-dd46037ad913
Can be tested on the deploy preview.