use-ink / contracts-ui

Web application for deploying wasm smart contracts on Substrate chains that include the FRAME contracts pallet
https://contracts-ui.substrate.io/
GNU General Public License v3.0
61 stars 44 forks source link

fix: removes unecessary encoding of salt during dryrun #553

Closed peetzweg closed 2 months ago

peetzweg commented 2 months ago

Closes #382.

The ui was encoding the salt during dryrunning the instantiate of contracts but not during the actual instantiation. Therefore the contract address shown from the dry run result was not matching the actual deployed contract address.

Video showing the bug before and after fix:

https://github.com/paritytech/contracts-ui/assets/839848/5a5b9b7b-a0b6-4697-883f-dd46037ad913

Can be tested on the deploy preview.

netlify[bot] commented 2 months ago

Deploy Preview for contracts-ui ready!

Name Link
Latest commit 1a6b445af17c6597141b5cb6d77cb3e55fed9eba
Latest deploy log https://app.netlify.com/sites/contracts-ui/deploys/6615341c5c48bd0008869af1
Deploy Preview https://deploy-preview-553--contracts-ui.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

cypress[bot] commented 2 months ago

Passing run #395 ↗ī¸Ž

0 61 0 0 Flakiness 0

Details:

Merge 1a6b445af17c6597141b5cb6d77cb3e55fed9eba into faac63dabb4f5562c299d4837e92...
Project: Contracts UI Commit: f3ab6cdb4e ℹī¸
Status: Passed Duration: 01:13 💡
Started: Apr 9, 2024 12:29 PM Ended: Apr 9, 2024 12:30 PM

Review all test suite changes for PR #553 ↗ī¸Ž

cypress[bot] commented 2 months ago

Passing run #397 ↗ī¸Ž

0 61 0 0 Flakiness 0
⚠ī¸ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.

Details:

fix: removes unecessary encoding of salt during dryrun (#553)
Project: Contracts UI Commit: f1d8c8ee14
Status: Passed Duration: 01:19 💡
Started: Apr 11, 2024 8:29 AM Ended: Apr 11, 2024 8:30 AM

Review all test suite changes for PR #553 ↗ī¸Ž