search

use-ink / ink-docs

Documentation portal for the ink! smart contract language.
https://use.ink
Creative Commons Zero v1.0 Universal
23 stars 70 forks source link

Fix alternative backend syntax example for DRink! #331

Closed davidsemakula closed 7 months ago

davidsemakula commented 7 months ago

See https://github.com/paritytech/ink/pull/2083

davidsemakula commented 7 months ago

@cmichi Additionally, the example link here is also broken. It can be fixed by linking to https://github.com/paritytech/ink/blob/master/integration-tests/e2e-runtime-only-backend/lib.rs but I think the intention was to copy that test over to the ink! examples repo?

cmichi commented 7 months ago

@davidsemakula Could you check that there's nothing to be updated for either https://github.com/paritytech/ink/pull/2143 nor https://github.com/paritytech/ink/pull/2140?

cmichi commented 7 months ago

@cmichi Additionally, the example link here is also broken. It can be fixed by linking to https://github.com/paritytech/ink/blob/master/integration-tests/e2e-runtime-only-backend/lib.rs but I think the intention was to copy that test over to the ink! examples repo?

Thanks for flagging it! We'll copy the test over. @smiasojed Can you take care of including this test in our public examples?

The intention behind the copying was that the ink-examples contain examples with a source code that fits the last published release, whereas the contracts in ink/integration-tests often already have some breaking unreleased changes in master.

davidsemakula commented 7 months ago

... Could you check that there's nothing to be updated for either paritytech/ink#2143 nor paritytech/ink#2140?

@cmichi confirmed 👍 5.x docs don't (mis)use any syntax that's been removed/changed by https://github.com/paritytech/ink/pull/2140, https://github.com/paritytech/ink/pull/2143 or https://github.com/paritytech/ink/pull/2146