search

useblocks / libpdf

Extract structured data from PDFs
MIT License
8 stars 2 forks source link

Color and font information for chars, words and boxes #39

Closed kreuzberger closed 7 months ago

kreuzberger commented 7 months ago

The PR is for discussion of issue #38. The non-stroking color information is stored if all characters in a word have same non-stroking color.

ubmarco commented 7 months ago

Can we try to merge https://github.com/useblocks/libpdf/pull/36 first to get the linting insights? It's almost done.

ubmarco commented 7 months ago

I merged PR https://github.com/useblocks/libpdf/pull/36, please add modified files to the tox.ini line that specifies the ruff paths, currently poetry run ruff tests/conftest.py tests/test_rects.py

kreuzberger commented 7 months ago

I merged PR #36, please add modified files to the tox.ini line that specifies the ruff paths, currently poetry run ruff tests/conftest.py tests/test_rects.py

How can i use different python versions with tox to check? Currently i have 3.10 installed in my system and 3.11 in a local venv. How can is use 3.12 (required for format/lint) in a special local tox environment? This would help me not to localy modify tox.ini all the time. or could the format/lint be more "Opened" for other python versions?

ubmarco commented 7 months ago

I just merged https://github.com/useblocks/libpdf/pull/40, please rebase your change on top of it. There might some merge conflicts. Btw, if you create your fork under your personal account, you can allow me to push to your PR branch (flag Allow edits by maintainers).

kreuzberger commented 7 months ago

I just merged #40, please rebase your change on top of it. There might some merge conflicts. Btw, if you create your fork under your personal account, you can allow me to push to your PR branch (flag Allow edits by maintainers).

Hi! I merged everything some weeks ago, but the PR is still open. Is there something missing? Or Just no time left :smile: