search

useblocks / sphinx-collections

Integrates different sources into one Sphinx project.
https://sphinx-collections.readthedocs.io/en/latest/
MIT License
18 stars 8 forks source link

Bug with ignore in PyPI released version #20

Open anugrahjo opened 1 year ago

anugrahjo commented 1 year ago

'ignore' does not work for copy and copy_folder drivers. ignore=ignore_patterns() is a kwarg for copytree() but is provided as a non-keyworded argument in copy and copy_folder drivers. Just adding the keyword ignore= will fix the issue. I see that copy driver is removed and this issue is also fixed in the github repo but not on PyPI released version. Is it possible to release the latest version on master branch to PyPI?

jgarte commented 1 year ago

Interesting, I was getting this error yesterday when trying to use the copy_folder driver:

ERROR: Error executing driver CopyFolderDriver for collection foo_bar. 'ignore'

I wonder if it is related. My source and target directory definitely exists as configured in my collections dictionary in conf.py.

Did you get a similar logger warning when trying to run the copy_folder driver?

jgarte commented 1 year ago

Also,

With the copy_file driver I experienced something the other day where it created a directory in the target location instead of copying my file.

jgarte commented 1 year ago

@anugrahjo

Have you been able to get copy_file and/or copy_folder driver to work without ignore?

anugrahjo commented 1 year ago

Interesting, I was getting this error yesterday when trying to use the copy_folder driver:

ERROR: Error executing driver CopyFolderDriver for collection foo_bar. 'ignore'

I wonder if it is related. My source and target directory definitely exists as configured in my collections dictionary in conf.py.

Did you get a similar logger warning when trying to run the copy_folder driver?

No, I did not.

anugrahjo commented 1 year ago

Have you been able to get copy_file and/or copy_folder driver to work without ignore?

No I think it always requires ignore. I give an empty list [] if I don't want to ignore any files.