search

useblocks / sphinx-needs

Adds needs/requirements to sphinx
https://sphinx-needs.readthedocs.io/en/latest/index.html
MIT License
213 stars 66 forks source link

The pygls.lsp.types module no longer exists #865

Closed ivanayov closed 1 year ago

ivanayov commented 1 year ago

In the latest pygls release, the pygls.lsp.types module no longer exists, which results to a build failure:

ModuleNotFoundError: No module named 'pygls.lsp.types'

I'm using sphinx-needs v1.2.0.

arwedus commented 1 year ago

@ivanayov: Thanks for reporting this issue, I have noticed this, too. Background: sphinx-needs is not yet compatible with pygls 1.0, but does not pin the version dependency to pygls<1.0.

@danwos: This is an issue if people upgrade esbonio to 0.16.0, which depends on pygls 1.0.

I see two options:

a) mini release which pins the version dependency of pygls b) migrating the pygls.lsp usage in esbonio.py

danwos commented 1 year ago

Thanks for reporting. A quick fix on your side would be to install esbonio < 0.16.

However, we are working on a fix, which allows supporting older and newer esbonio versions: #868.

We don't want to pin the version or support only newer versions in our code, as I see scenarios, where older versions may still be needed in the currently used Python env. For instance: The Restructured-VsCode-Extension may force us to use the older esbonio version.

I hope we can merge the PR today and create a new release.

danwos commented 1 year ago

This got fixed by #868. I will create a new release shortly.

Thanks all for the help :+1: