useblocks / sphinx-needs

Adds needs/requirements to sphinx
https://sphinx-needs.readthedocs.io/en/latest/index.html
MIT License
213 stars 66 forks source link

Incompatible with esbonio 0.16.0 #867

Closed ubmarco closed 1 year ago

ubmarco commented 1 year ago

esbonio 0.16.0 got released on 4th of Feb 2023. sphinx-needs uses esbonio = ">=0.11.3" which auto-installs 0.16.0.

This leads to

  File "/home/marco/test/docs/.venv/lib/python3.8/site-packages/sphinx_modeling/__init__.py", line 3, in <module>
    from sphinx_modeling.setup import setup  # needed by Sphinx to configure the extension  # noqa: F401
  File "/home/marco/test/docs/.venv/lib/python3.8/site-packages/sphinx_modeling/setup.py", line 11, in <module>
    from sphinx_needs.api import add_dynamic_function, add_extra_option, add_need_type
  File "/home/marco/test/docs/.venv/lib/python3.8/site-packages/sphinx_needs/__init__.py", line 1, in <module>
    from sphinx_needs.lsp.esbonio import esbonio_setup  # noqa: F401
  File "/home/marco/test/docs/.venv/lib/python3.8/site-packages/sphinx_needs/lsp/esbonio.py", line 10, in <module>
    from esbonio.lsp import LanguageFeature
  File "/home/marco/test/docs/.venv/lib/python3.8/site-packages/esbonio/lsp/__init__.py", line 14, in <module>
    from lsprotocol.types import COMPLETION_ITEM_RESOLVE
ModuleNotFoundError: No module named 'lsprotocol'

I guess constraining the upper version to esbonio<0.16.0 is the right decision as it is about to be removed anyway.

arwedus commented 1 year ago

possible duplicate of #865

danwos commented 1 year ago

Closed because of duplicate of #865.