useblocks / sphinx-simplepdf

A simple PDF builder for Sphinx documentations
https://sphinx-simplepdf.readthedocs.io
MIT License
36 stars 15 forks source link

[#19] Customization of PDF Header/Footer with simplepdf_vars #20

Closed kreuzberger closed 1 year ago

kreuzberger commented 1 year ago

Hi!

Here is my first try to implement this feature with simplepdf_vars and adapted _variables/_pages.scss. This should not break your default layout. The settings for the footer are taken from back-cover and could be adapted.

Cause i am not very familiar with css, the _pages.scss contains many repetitions. Maybe this could be optimized. Maybe depending on the content for the top-left heading entry, there might be the need for a width variable there, cause its currently hard coded to 1cm.

Feel free to comment / improve!

danwos commented 1 year ago

Thanks for the PR :+1: I was not able to push some minor doc-changes to your branch. Therefore I needed to create a new PR, which contains your changes as well: #21

This got already merged, so the review for this PR already passed :)

I close this PR, as it is part of #21.

Update: Okay, it got automatically closed/merged, as it is completely part of another PR. Good to know.