Closed 1kastner closed 2 years ago
My propositions are twofold:
That would be great! Thanks a lot for your time and effort!
Thanks for reporting. Looks like my code for manipulating some internal HTML data is not well written and does not really handle encoding.
I will check this and add some tests.
Encodings are always tricky! I try to always use UTF8 but Windows defaults to that CP1252 encoding which also appears in the trace.
Ok, I added a small fix to the main
branch.
It sets encoding always to utf-8 for the file operations.
Thanks for the hint with the default value and the different selection on windows.
I need to find some time to set up the CI for this project and test it on windows as well.
If you like, you could checkout the main
branch for me and test it again :)
Thanks, the encoding issue is solved and at the end of the process, a PDF shows up! To be honest, there are some issues with the PDF. However, this specific issue is solved. Thanks for the quick fix!
@1kastner - are you facing any issues while translating the PDFs, like some of the Unicode characters not getting printed on the PDF? Is this issue talking on similar lines?
Nope, this closed issue is on file-level i/o.
Thank you very much for the project and your effort! I ran
.\docs\make.bat simplepdf
on one of my projects and just got this decode error here:I thought I just used English characters in Unicode but obviously I am mistaken. But the conversion happens so lately that I have no idea which file is at fault. Furthermore, in HTML everything looks fine so I would be most happy if the PDF was just built without any change.